Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom HttpClient support #67

Closed
SchutzeHades opened this issue Mar 21, 2018 · 1 comment
Closed

Custom HttpClient support #67

SchutzeHades opened this issue Mar 21, 2018 · 1 comment

Comments

@SchutzeHades
Copy link

Hi, I noticed that this client uses org.apache.http.client.HttpClient and provides a constructor taking an HttpClientBuilder as a parameter. But in my situation, I want one more constructor that takes an org.apache.http.client.HttpClient as a parameter, because my http client is created by another library and there's no way to get that kind of builder object. Currently I extends org.kairosdb.client.HttpClient and replace the inner client using org.kairosdb.client.HttpClient#setClient method which is intended to be a test method. I suppose this may be a common situation and wonder if there are any plans to support this. Thank you.

@jsabin
Copy link
Contributor

jsabin commented Aug 14, 2018

Fixed in 7b7fd3f in the development branch.

@jsabin jsabin closed this as completed Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants