add e2e s3 test #7833
Merged
add e2e s3 test #7833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
approved these changes
Jun 28, 2023
dereknola
approved these changes
Jun 29, 2023
| fmt.Println(a) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
We need additional checks to insure that the s3 snapshot can successfully be listed or queried.
osodracnai
force-pushed
the
s3-e2e-test
branch
2 times, most recently
from
926c546
to
be79534
Compare
dereknola
approved these changes
Jun 30, 2023
|
You need to go fmt your files for CI to pass. |
Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7833 +/- ##
==========================================
+ Coverage 47.22% 51.52% +4.29%
==========================================
Files 143 143
Lines 14509 14524 +15
==========================================
+ Hits 6852 7483 +631
+ Misses 6571 5855 -716
- Partials 1086 1186 +100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
osodracnai
added a commit
to osodracnai/k3s
that referenced
this pull request
Jul 6, 2023
Signed-off-by: Ian Cardoso <osodracnai@gmail.com> (cherry picked from commit 9e33415)
osodracnai
added a commit
to osodracnai/k3s
that referenced
this pull request
Jul 6, 2023
Signed-off-by: Ian Cardoso <osodracnai@gmail.com> (cherry picked from commit 9e33415)
osodracnai
added a commit
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Ian Cardoso <osodracnai@gmail.com> (cherry picked from commit 9e33415)
osodracnai
added a commit
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Ian Cardoso <osodracnai@gmail.com> (cherry picked from commit 9e33415)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
adds e2e test checking s3-etcd-snapshot functionality, closes #7441
Types of Changes
Verification
Testing
go test -timeout=15m ./tests/e2e/s3/...Linked Issues
User-Facing Change
Further Comments