Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point people to the browser extension #231

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

yuvipanda
Copy link
Contributor

It is less error prone for the most common use case,
as you can just browse on GitHub and get the link immediately.
No need to figure out branch name, filepath, etc.

See launch announcement in https://words.yuvi.in/post/nbgitpuller-link-generator-extension/

It is less error prone for the most common use case,
as you can just browse on GitHub and get the link immediately.
No need to figure out branch name, filepath, etc.

See launch announcement in https://words.yuvi.in/post/nbgitpuller-link-generator-extension/
@yuvipanda
Copy link
Contributor Author

yuvipanda commented Nov 16, 2021

screenshot-popover

This is how it looks.

docs/link.rst Outdated Show resolved Hide resolved
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both the website and the browser extension has a purpose, so I appreciate introducing this as an additional option as this PR does. Nice work @yuvipanda!

@consideRatio
Copy link
Member

This is how it looks.

The image upload seem to have failed @yuvipanda!

Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
@yuvipanda
Copy link
Contributor Author

Thanks, @consideRatio! I uploaded the image properly this time :)

@consideRatio consideRatio merged commit 2928721 into jupyterhub:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants