-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix junit-platform-commons-java-9 subproject build #1288
Conversation
Overriding compiler args can lead to missing arguments
Otherwise, changing `javacRelease` extension property in a subproject does not affect compiler config.
Codecov Report
@@ Coverage Diff @@
## master #1288 +/- ##
============================================
- Coverage 91.35% 91.31% -0.04%
+ Complexity 3123 3122 -1
============================================
Files 295 295
Lines 7646 7646
Branches 624 624
============================================
- Hits 6985 6982 -3
- Misses 484 485 +1
- Partials 177 179 +2
Continue to review full report at Codecov.
|
Tried your changes locally and building it on console and importing the project into IDEA 2018.1 EAP works like a charm:
Does this fix also work with older versions of IDEA? |
Yes, it should be fixed for older versions. |
Thank you very much, @nskvortsov |
Append compiler args. Overriding compiler args can lead to missing arguments Postpone configuration of java compiler. Otherwise, changing `javacRelease` extension property in a subproject does not affect compiler config.
Overview
Update Gradle script so that subproject
junit-platform-commons-java-9
is really built with source, target and API of Java 9.Before, two things were happening:
--release
compiler option was missing and all modules were compiler against JDK9 APIjavacRelease = 9
did not work for the subproject, because compiler settings were configured too early.This was spotted while trying to import the project to IntelliJ IDEA https://youtrack.jetbrains.com/issue/IDEA-186344
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations