ili9488 module. #148
Merged
ili9488 module. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r. Does not currently work on my setup.
…model ER-TFT035-6. It was based on the ili9486L. The initialization code was replaced with the ili9488 sequence found in the BuyDisplay.com demo code for micro controllers. The rest of the code was left untouched, it seems the 9486 and 9488 share functionality.
|
Don't approve this, just realized I forgot to back out some changes done for testing. |
|
Ok, sorry for the mess up. I backed out the changes that should not be a part of this request. It should be good to go now but do let me know if you want anything changed or corrected. |
juj
reviewed
Jun 22, 2020
juj
reviewed
Jun 22, 2020
|
Very nice work! Code looks all good, just a few questions regarding hooking up to the existing options. |
|
I agree, let me look at these settings and see how the flags will apply. |
…ntation by reading the compiler definition flags.
|
@juj updates are ready for review. |
|
Awesome, thanks! |
|
No problem, you are welcome. Thank you for sharing your work with the rest of us. Thanks also to @hakmo who tested and made the idea work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module adds support for the ili9488 TFT controller. The basis for this module was the ili9486L driver that already existed in the code. The initialization calls were replaced with those found in sample code intended for micro controllers. It was tested with the 3.5" 320x480 display model ER-TFT035-6 from BuyDisplay.com.