Remove all code that relies on onbeforeunload but keep Angulor's st…

…ate change detection
jpfss · Apr 13, 2017 · c13ef9f · c13ef9f
1 parent e680639
commit c13ef9f
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 80 deletions.
diff --git a/app/assets/javascripts/application.js.erb b/app/assets/javascripts/application.js.erb
@@ -48,7 +48,6 @@
 //= require top-shelf
 //= require unsupported-browsers
 //= require autocomplete_textareas
-//= require warn_leaving_unsaved
 //= require openproject_plugins
 //= require versions
 //= require_tree ./specific

diff --git a/app/assets/javascripts/warn_leaving_unsaved.js b/app/assets/javascripts/warn_leaving_unsaved.js
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
@@ -611,16 +611,6 @@ def user_specific_javascript_includes
       I18n.defaultLocale = "#{I18n.default_locale}";
       I18n.locale = "#{I18n.locale}";
     })
-    if User.current.pref.warn_on_leaving_unsaved?
-      tags += javascript_tag(%{
-        jQuery(document).ready(function(){
-          warnLeavingUnsaved('#{escape_javascript(l(:text_warn_on_leaving_unsaved))}');
-          jQuery(document).ajaxComplete(function(){
-            warnLeavingUnsaved('#{escape_javascript(l(:text_warn_on_leaving_unsaved))}')
-          });
-        });
-      })
-    end
 
     tags.html_safe
   end

diff --git a/frontend/app/components/wp-edit/wp-edit-mode-state.service.ts b/frontend/app/components/wp-edit/wp-edit-mode-state.service.ts
@@ -41,7 +41,6 @@ export class WorkPackageEditModeStateService {
     protected $q:ng.IQService,
     protected I18n:op.I18n) {
     const confirmText = I18n.t('js.work_packages.confirm_edit_cancel');
-    const cancelEventName = 'beforeunload.confirm_cancel';
     const requiresConfirmation = ConfigurationService.warnOnLeavingUnsaved();
 
     $rootScope.$on('$stateChangeStart', (event, toState, toParams, fromState, fromParams) => {
@@ -55,20 +54,6 @@ export class WorkPackageEditModeStateService {
         this.cancel();
       }
     });
-
-    // Show confirmation message when browsing to a new page
-    angular.element($window).on(cancelEventName, (event:JQueryEventObject):string|void => {
-      if (requiresConfirmation && this.active) {
-        (event as any).returnValue = confirmText;
-        event.preventDefault();
-
-        return confirmText;
-      }
-    });
-
-    $rootScope.$on('$destroy', () => {
-      return angular.element($window).off(cancelEventName);
-    });
   }
 
   public start():boolean {