Rename method arguments to use camelCase casing (plugin directory) #31151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on c87c887 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31151. |
zero-24
reviewed
Oct 19, 2020
| @@ -93,25 +93,25 @@ public function onContentPrepare($context, &$row, $params, $page = 0) | |||
| /** | |||
| * Retrieve Contact | |||
| * | |||
| * @param int $created_by Id of the user who created the contact | |||
| * @param int $userId Id of the user who created the article | |||
There was a problem hiding this comment.
Suggested change
| * @param int $userId Id of the user who created the article | |
| * @param int $userId Id of the user who you want to get the contact data |
There was a problem hiding this comment.
Is this correct English though?
There was a problem hiding this comment.
I'm sure it is not but it gets closer to what it happening here right?
There was a problem hiding this comment.
what about
* @param int $userId Id of the user from whom to get the contact data
|
I have tested this item ✅ successfully on c87c887 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31151. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31151. |
joomla-cms-bot
added
RTC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Pull Request for Issue #30988.
Summary of Changes
Renames some method arguments to use camelCase casing.
Testing Instructions
Thorough code review / Joomla works like before.
Documentation Changes Required
No.