-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Fix debug logging. Move logging to application #30317
Conversation
Co-authored-by: Brian Teeman <brian@teeman.net>
I have tested this item ✅ successfully on 0275ab9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30317. |
Previous test by @toivo is still valid because last change only was a typo correction in a language string. I've restored the test result in the issue tracker. |
I have tested this item ✅ successfully on 31e7e77 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30317. |
@Fedik To save you time, I've allowed myself to commit the typo correction for the language string directly to your branch. I hope you are ok with that. If not, let me know and I'll never do it again. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30317. |
I have tested this item ✅ successfully on 31e7e77
php: Linux lamp121.cloudaccess.net 2.6.32-673.8.1.lve1.4.3.1.el6.x86_64 #1 SMP Thu May 5 16:06:47 EDT 2016 x86_64 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30317. |
@wilsonge Anything keeps this from being merged? |
This is try to fix Release Blocker #25675 .
Summary of Changes
This will move logging set up to application level. The plugin used only for display them.
One of new feature here, that the logging may be enabled even when the debugging is Off.
Testing Instructions
Be aware: there a thousands of Deprecated entries, if you have a slow PC / server, be patient.
Apply patch. Go to Global Configuration and enable Debug, also enable Log Deprecated API.
Enable System Debug plugin, and set "Show logs" in the plugin.
In the debugger toolbar you should be able to see much of entries of Deprecated call.
Actual result BEFORE applying this Pull Request
No Deprecated entries, or only few of them.
Expected result AFTER applying this Pull Request
A loot of entries
Documentation Changes Required
Yes I guess. Logging moved to Global configuration, and can be enabled there.