-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly merge tag params #13643
Properly merge tag params #13643
Conversation
will test today. |
Test-Scenario:
|
The error was a typo on my part. Can you try again? |
menuitem |
|
The parameter for the image float seems to be not used at all in com_tags. That would be a different PR to add this, but not one I'm going to write 😄 |
made #13646 |
I have tested this item ✅ successfully on 28dc518 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13643. |
Thanks for getting to this one so quickly! I will test it out now. |
I have tested this item ✅ successfully on 28dc518 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13643. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13643. |
@justinherrin does
mean i can close #13646? |
Pull Request for Issue #13641.
Summary of Changes
I don't know what to say after looking at that code... That stuff certainly didn't work at all before.
In short, item and menu params are now properly merged.
Testing Instructions
Test that tag parameters are merged properly, meaning that options set in the tag override those in the menu item. Except when the menu item is an exact match to the tag (eg it's a single tag menuitem for that specific tag shown), then the menu item takes precedence over the tag params
Documentation Changes Required
None.