Changing search shard failure logging to trace from debug (opensearch…

…-project#8470) * Changing shard failure logging to trace from debug * Moving the exception to trace logs Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
jojiseb · Jul 14, 2023 · e8f1c30 · e8f1c30
1 parent 6a19660
commit e8f1c30
Showing 1 changed file with 21 additions and 9 deletions.
diff --git a/server/src/main/java/org/opensearch/action/search/AbstractSearchAsyncAction.java b/server/src/main/java/org/opensearch/action/search/AbstractSearchAsyncAction.java
@@ -455,15 +455,27 @@ private void onShardFailure(final int shardIndex, @Nullable SearchShardTarget sh
             .findNext(shardIt, clusterState, e, () -> totalOps.incrementAndGet());
 
         final boolean lastShard = nextShard == null;
-        logger.debug(
-            () -> new ParameterizedMessage(
-                "{}: Failed to execute [{}] lastShard [{}]",
-                shard != null ? shard : shardIt.shardId(),
-                request,
-                lastShard
-            ),
-            e
-        );
+        if (logger.isTraceEnabled()) {
+            logger.trace(
+                () -> new ParameterizedMessage(
+                    "{}: Failed to execute [{}] lastShard [{}]",
+                    shard != null ? shard : shardIt.shardId(),
+                    request,
+                    lastShard
+                ),
+                e
+            );
+        } else {
+            // Log the message without an exception.
+            logger.debug(
+                new ParameterizedMessage(
+                    "{}: Failed to execute [{}] lastShard [{}]",
+                    shard != null ? shard : shardIt.shardId(),
+                    request,
+                    lastShard
+                )
+            );
+        }
         if (lastShard) {
             onShardGroupFailure(shardIndex, shard, e);
         }