Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use source instead of creating a subshell #122

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Use source instead of creating a subshell #122

merged 1 commit into from
Jun 26, 2024

Conversation

stevefan1999-personal
Copy link
Contributor

So that the environment values can be inherited from the pre/post scripts and propagate to the launch options, which is especially great for Agones scripting

joedwards32
joedwards32 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Owner

@joedwards32 joedwards32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I hadn't considered this, useful for passing data as environment between pre and post

@joedwards32 joedwards32 merged commit 4bfd461 into joedwards32:main Jun 26, 2024
2 checks passed
@joedwards32
Copy link
Owner

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joedwards32 joedwards32 joedwards32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevefan1999-personal @joedwards32