Skip to content

Commit

Permalink
api: mark the unified matcher API as stable (envoyproxy#30112)
Browse files Browse the repository at this point in the history
Commit Message: The API is now used in many places and must follow safe deprecation practices.
Additional Description:
Risk Level: low
Testing: none
Docs Changes:
Release Notes:
Platform Specific Features:
  • Loading branch information
kyessenov committed Oct 11, 2023
1 parent 1b08035 commit be01f8a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
1 change: 0 additions & 1 deletion api/envoy/config/common/matcher/v3/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ api_proto_package(
"//envoy/config/route/v3:pkg",
"//envoy/type/matcher/v3:pkg",
"@com_github_cncf_udpa//udpa/annotations:pkg",
"@com_github_cncf_udpa//xds/annotations/v3:pkg",
],
)
7 changes: 3 additions & 4 deletions api/envoy/config/common/matcher/v3/matcher.proto
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import "envoy/config/core/v3/extension.proto";
import "envoy/config/route/v3/route_components.proto";
import "envoy/type/matcher/v3/string.proto";

import "xds/annotations/v3/status.proto";

import "udpa/annotations/status.proto";
import "validate/validate.proto";

Expand All @@ -24,9 +22,10 @@ option (udpa.annotations.file_status).package_version_status = ACTIVE;
// is found the action specified by the most specific on_no_match will be evaluated.
// As an on_no_match might result in another matching tree being evaluated, this process
// might repeat several times until the final OnMatch (or no match) is decided.
//
// .. note::
// Please use the syntactically equivalent :ref:`matching API <envoy_v3_api_msg_.xds.type.matcher.v3.Matcher>`
message Matcher {
option (xds.annotations.v3.message_status).work_in_progress = true;

// What to do if a match is successful.
message OnMatch {
oneof on_match {
Expand Down

0 comments on commit be01f8a

Please sign in to comment.