Fix publish to multiple channels. Add unit tests. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note that this relates to issue #98. |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
I've reviewed this and understand what's going on. I'm going to mark this as candidate to merge after I test it locally. |
Nooba
pushed a commit
to Nooba/slack-plugin
that referenced
this pull request
Oct 26, 2015
Add unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change to get the test connection working unfortunately broke sending messages to multiple channels. This PR fixes that, and adds unit tests to (hopefully) cover all the scenarios.