Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth and reset #20

Merged
merged 3 commits into from
Oct 11, 2014
Merged

Depth and reset #20

merged 3 commits into from
Oct 11, 2014

Conversation

dwarburt
Copy link

I've added two features for this plugin: support for shallow clones, option to reset the repo before syncing.

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@dwarburt
Copy link
Author

Any review of this pull request? We've been using this code in our development at $DAYJOB for a few months with no issues.

@@ -0,0 +1,5 @@
<div>
<p>
When this is checked the first thing to do will be a <pre>repo forall -c "git reset --hard"</pre>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't repo sync -d accomplish the same?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, not quite the same. both "repo sync" and "repo sync -d" will report an error if local uncommitted changes would be lost in the sync.

@rsandell
Copy link
Member

Well, it looks good to me. But @aep has done a few releases not long ago, so I'd prefer to wait a bit longer to see if he responds. So I don't step on anyone's toes by merging.

aep added a commit that referenced this pull request Oct 11, 2014
@aep aep merged commit 8481d85 into jenkinsci:master Oct 11, 2014
@aep
Copy link
Member

aep commented Oct 11, 2014

Looks good to me. @rsandell i'd be delighted if you could step in actually. I changed dayjobs and won't be able to spend much time with jenkins for a few months unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants