Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change deployment target to iOS 9 to fix Archiving with Xcode 12 #608

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

dvshelley
Copy link

No description provided.

@simonyangme
Copy link

@matej any chance you can take a look at this PR? iOS 8 is no longer supported as a deployment target with Xcode 12's release.

@tinder-owenthomas
Copy link
Contributor

Bump for this one. We cannot upgrade to Xcode 12 until this warning can be silenced. Any chance of getting this merged and a new version released?

@matej
Copy link
Collaborator

matej commented Nov 20, 2020

This is pretty easy to work around by adding something like the following in your pod file:

post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '9.0'
    end
  end
end

I use that myself.

That being said, I think it's fine to jump to V9. Based on a quick check, I don't see any new warnings.

@matej matej merged commit 9bed527 into jdg:master Nov 20, 2020
@tinder-owenthomas
Copy link
Contributor

tinder-owenthomas commented Nov 21, 2020

@matej I think it needs to be updated here as well https://github.com/jdg/MBProgressHUD/blob/master/MBProgressHUD.podspec#L15

And any chance we can get a tagged version bump to 1.3.0 so we can pull these changes in without having to point to a commit? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants