Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focusing: focus/blur #282

Merged
merged 34 commits into from
Aug 16, 2023
Merged

Focusing: focus/blur #282

merged 34 commits into from
Aug 16, 2023

Conversation

shahrzadJavadiKoushesh
Copy link
Contributor

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team August 11, 2023 12:55
@javascript-translate-bot javascript-translate-bot mentioned this pull request Aug 9, 2023
Open
mahdiHash
mahdiHash suggested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@mahdiHash mahdiHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

سلام @shahrzadJavadiKoushesh.
بابت مشارکت شما ممنونم.
لطفا به برابر بودن خط‌های اضافه و حذف شده بین مقاله اصلی و مقاله ترجمه شده توجه کنین. این دو مورد باید برابر باشن.
این مشکل رو برطرف کنین و بعدش /done رو کامنت کنین.

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot javascript-translate-bot requested a review from a team August 13, 2023 17:49
mahdiHash
mahdiHash suggested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@mahdiHash mahdiHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

لطفا کامنت‌ها رو نگاه بندازین و به تغییراتی که باید روی کل مقاله اعمال بشن هم توجه کنین.
می‌تونین تمام suggestionها رو داخل یه دسته قرار بدین و با هم کامیت کنین (docs)

2-ui/4-forms-controls/2-focus-blur/3-editable-div/task.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/3-editable-div/task.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/4-edit-td-click/solution.md Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/5-keyboard-mouse/solution.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/5-keyboard-mouse/task.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@shahrzadJavadiKoushesh
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team August 14, 2023 15:03
mahdiHash
mahdiHash suggested changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@mahdiHash mahdiHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

لطفا مشکل خط‌های ۱۰۰ تا ۱۰۳ و خط ۱۷۶ هم برطرف کنین.

2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@shahrzadJavadiKoushesh
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team August 16, 2023 12:25
@mahdiHash
Copy link
Contributor

مرسی از همراهی‌تون @shahrzadJavadiKoushesh :)

@mahdiHash mahdiHash merged commit 1d24444 into javascript-tutorial:master Aug 16, 2023
1 check passed
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@shahrzadJavadiKoushesh
Copy link
Contributor Author

ممنون از کمک‌های شما

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahdiHash mahdiHash mahdiHash approved these changes

Assignees

@mahdiHash mahdiHash

Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahrzadJavadiKoushesh @javascript-translate-bot @mahdiHash