Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse events #149

Merged
merged 6 commits into from
Sep 11, 2021
Merged

Mouse events #149

merged 6 commits into from
Sep 11, 2021

Conversation

erfanyeganegi
Copy link
Contributor

No description provided.

@mahdyar mahdyar changed the title mouse-event-basics Mouse events Sep 10, 2021
Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @erfanyeganegi and thank you for your contribution!
Please consider naming your PR after the article name for future PRs (Read the readme if you haven't):

PR title should match article title, the bot will write it's number into the issue.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

make the requested changes.
This reverts commit 255c30a.
made the requested changes and improved translation.
@erfanyeganegi
Copy link
Contributor Author

/done

Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned some of the problems below, please check it again for any similar problems.
Line numbers shouldn't change.

Comment on lines 59 to 65
| `event.button` | وضعیت کلید |
| -------------- | ----------------- |
| 0 | کلید چپ (اصلی) |
| 1 | کلید وسط (کمکی) |
| 2 | کلید راست (ثانوی) |
| 3 | کلید X1 (عقب) |
| 4 | کلید X2 (جلو) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't add spaces here either.

}
};
</script>
```
````
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't change the format of the article. The last back quote is extra.

```warn header="Attention: on Mac it's usually `Cmd` instead of `Ctrl`"
On Windows and Linux there are modifier keys `key:Alt`, `key:Shift` and `key:Ctrl`. On Mac there's one more: `key:Cmd`, corresponding to the property `metaKey`.
```warn header="توجه: روی مک معمولا `Cmd`بجای`Ctrl`خواهد بود" روی ویندوز و لینوکس کلیدهای اصلاح‌کننده `key:Alt`, `key:Shift`و`key:Ctrl`وجود خواهد داشت. روی مک یک کلید دیگر نیز وجود دارد: `key:Cmd`, متناظر خاصیت `metaKey`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't merge them in one line.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@erfanyeganegi
Copy link
Contributor Author

/done

Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @erfanyeganegi!

@mahdyar mahdyar merged commit c0c5540 into javascript-tutorial:master Sep 11, 2021
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@erfanyeganegi erfanyeganegi deleted the mouse-event-basics branch September 11, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants