-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mouse events #149
Mouse events #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @erfanyeganegi and thank you for your contribution!
Please consider naming your PR after the article name for future PRs (Read the readme if you haven't):
PR title should match article title, the bot will write it's number into the issue.
2-ui/3-event-details/1-mouse-events-basics/01-selectable-list/solution.view/index.html
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/1-mouse-events-basics/01-selectable-list/solution.view/index.html
Outdated
Show resolved
Hide resolved
Please make the requested changes. After it, add a comment "/done". |
make the requested changes.
This reverts commit 255c30a.
made the requested changes and improved translation.
/done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned some of the problems below, please check it again for any similar problems.
Line numbers shouldn't change.
| `event.button` | وضعیت کلید | | ||
| -------------- | ----------------- | | ||
| 0 | کلید چپ (اصلی) | | ||
| 1 | کلید وسط (کمکی) | | ||
| 2 | کلید راست (ثانوی) | | ||
| 3 | کلید X1 (عقب) | | ||
| 4 | کلید X2 (جلو) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't add spaces here either.
} | ||
}; | ||
</script> | ||
``` | ||
```` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't change the format of the article. The last back quote is extra.
```warn header="Attention: on Mac it's usually `Cmd` instead of `Ctrl`" | ||
On Windows and Linux there are modifier keys `key:Alt`, `key:Shift` and `key:Ctrl`. On Mac there's one more: `key:Cmd`, corresponding to the property `metaKey`. | ||
```warn header="توجه: روی مک معمولا `Cmd`بجای`Ctrl`خواهد بود" روی ویندوز و لینوکس کلیدهای اصلاحکننده `key:Alt`, `key:Shift`و`key:Ctrl`وجود خواهد داشت. روی مک یک کلید دیگر نیز وجود دارد: `key:Cmd`, متناظر خاصیت `metaKey`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't merge them in one line.
Please make the requested changes. After it, add a comment "/done". |
/done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @erfanyeganegi!
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
No description provided.