Fix for issue #55: ThreadMonitor waits unnecessarily #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change provides a fix and test for issue #55: #55 In ThreadMonitor in the call to wait on the monitor object. It's possible that the threadToMonitor was already set and the monitor notification sent. In that case, the monitor wait goes to the maximum value for the cpu time limit. The fix is to first verify that the threadToMonitor is null within the synchronized block and before the wait on the monitor.
|
Sorry for the delay! Looks all perfect, thank you! |
mxro
pushed a commit
that referenced
this pull request
May 4, 2018
tangrammer
added a commit
to tangrammer/delight-nashorn-sandbox
that referenced
this pull request
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides a fix and test for issue #55:
#55
In ThreadMonitor in the call to wait on the monitor object. It's
possible that the threadToMonitor was already set and the monitor
notification sent. In that case, the monitor wait goes to the
maximum value for the cpu time limit.
The fix is to first verify that the threadToMonitor is null within
the synchronized block and before the wait on the monitor.