Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nan/inf default values #284

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Support nan/inf default values #284

merged 1 commit into from
Mar 14, 2022

Conversation

mattico
Copy link
Contributor

@mattico mattico commented Mar 11, 2022

These are allowed in the FlatBuffer schema language.

@jamescourtney
Copy link
Owner

Thank you for this! I hadn't even considered this. Appreciate you putting together a PR with tests. I'll take a look this weekend.

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #284 (9123072) into main (8881a32) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   95.63%   95.63%   -0.01%     
==========================================
  Files         113      113              
  Lines        7587     7598      +11     
  Branches      703      706       +3     
==========================================
+ Hits         7256     7266      +10     
  Misses        230      230              
- Partials      101      102       +1     
Impacted Files Coverage Δ
...atSharp.Compiler/SchemaModel/PropertyFieldModel.cs 92.69% <100.00%> (+0.38%) ⬆️
src/FlatSharp/FlatBufferSerializer.cs 89.00% <0.00%> (-1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8881a32...9123072. Read the comment docs.

@jamescourtney jamescourtney merged commit 057b109 into jamescourtney:main Mar 14, 2022
@mattico mattico deleted the special-float branch July 11, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants