Issue 561 #574
Merged
Issue 561 #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonihele
approved these changes
Mar 2, 2024
|
Cheers 🎉 . I'll keep this open since I want to do some more testing before merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a weird one.
I think it's a regression from when I fixed something related to this a while back. The issue happens when a different texture was changed because the loaded flip and repeat weren't persisted.
I was tempted to rewrite a bit how it functioned, but also wanted to consider extra texture options (iirc that is another issue further down the list).
This refactor handles that, but I'm not sure the rest of the SDK does. At least if you try to enter something manually after the texture name, there will be a warning.
Not sure whether to keep it, or not allow anything after the texture name.
Fixes #561 and I think also #562