Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error msg to match jsonrpc method #596

Merged
merged 1 commit into from
Oct 24, 2021
Merged

Fix error msg to match jsonrpc method #596

merged 1 commit into from
Oct 24, 2021

Conversation

langep
Copy link
Contributor

@langep langep commented Oct 10, 2021

I think the error message should complain indicate failure to parse the "answer" instead of "offer" because this case handles an incoming answer.

@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #596 (576e334) into master (8d95f9f) will increase coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
+ Coverage   35.20%   35.89%   +0.68%     
==========================================
  Files          24       24              
  Lines        2619     2619              
==========================================
+ Hits          922      940      +18     
+ Misses       1558     1540      -18     
  Partials      139      139              
Impacted Files Coverage Δ
pkg/sfu/router.go 46.19% <0.00%> (+3.50%) ⬆️
pkg/sfu/subscriber.go 56.41% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d95f9f...576e334. Read the comment docs.

@langep langep assigned langep and unassigned langep Oct 10, 2021
Copy link
Contributor

@adwpc adwpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwpc adwpc merged commit 545bd59 into ionorg:master Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants