fix(combobox): unexpected overlay opening

[maxevilmind]

What I did

Added condition to check if overlay should be opened, but this change breaks 17 unit tests due to differences between programmatic actions in unit tests and actual UI behavior. Verified that affected scenarios function as expected in the UI.

Unit tests need further work as discussed with @okadurin. He confirmed the unexpected unit tests behavior.

Reproduction scenario of a bug I am trying to fix:

1. Override _showOverlayCondition with return false to simplify the use case when subclassers override this method and return false due to some logic.
2. Go to the multiple choice combobox and start typing
3. You will notice that the overlay opens on keydown and closes on key release. Input is cleared as a side-effect.

Please see what kind of fix could be applied to unit tests.

[changeset-bot]

⚠️ No Changeset found

Latest commit: f9ebfd7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[maxevilmind]

As an example of failed programmatic interaction we can use this test:
clears textbox after selection of a new item on click
It fails on expect(el.opened).to.equal(true);
After mimicking user typing the overlay does not open, while in the UI it opens as expected.
Similar behavior is observable in the other tests.