Input prometheus, use the same timestamp per call if no time is provided #7063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssoroka
reviewed
Feb 21, 2020
avoid the chance to have different timestamp during iteration of each metric for one http.Response Signed-off-by: Anthony ARNAUD <github@anthony-arnaud.fr>
aarnaud
force-pushed
the
prometheus-metrics-align
branch
from
4da902f
to
2c98cd0
Compare
ssoroka
approved these changes
Feb 25, 2020
|
Do you now when the next release is plan ? Can I made a PR to have a bugfix on 1.12 or 1.13 soon ? |
|
As soon as it's merged we'll back port it to 1.13.x (probably 1.13.4). Just waiting for @danielnelson to approve. |
danielnelson
approved these changes
Feb 25, 2020
danielnelson
pushed a commit
that referenced
this pull request
Feb 25, 2020
(cherry picked from commit 8c99dc7)
|
thanks @danielnelson for quick release. It's appreciate |
|
Sorry about this, currently it takes us a bit of time to get the official containers updated and unfortunately it isn't an automatic process. There are two places you can keep an eye on for progress updates:
|
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid the chance to have different timestamp during iteration of each
metric for one http.Response
This PR, fix an issue we discover. some time during the iteration of metrics, the timestamp change to pass to the next second and our metrics aren't align.
This only applied if TimestampMs is not provided in the prometheus metrics
Required for all PRs: