Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass empty measurement name to AddFields #4849

Merged
merged 2 commits into from
Oct 17, 2018
Merged

Conversation

glinton
Copy link
Contributor

@glinton glinton commented Oct 11, 2018

Resolves #4816

@danielnelson
Copy link
Contributor

We should configure the parser to produce metrics with names, let's set the measurement name to the defealt in Start, make sure that ParseLine returns the metric with a name and we can call m.Name() to pass it to acc.AddFields.

@danielnelson danielnelson added this to the 1.8.2 milestone Oct 12, 2018
@glinton glinton self-assigned this Oct 17, 2018
@glinton glinton merged commit 7df14d1 into release-1.8 Oct 17, 2018
@glinton glinton deleted the bugfix/4816 branch October 17, 2018 18:44
glinton added a commit that referenced this pull request Oct 17, 2018
marcosnils added a commit to marcosnils/telegraf that referenced this pull request Oct 23, 2018
marcosnils added a commit to marcosnils/telegraf that referenced this pull request Oct 23, 2018
Fixes influxdata#4849

Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants