Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated ZFS measurements for ZFS on Linux version 0.7.1 #3565

Merged
merged 2 commits into from
Jan 4, 2018

Conversation

richardelling
Copy link
Contributor

Required for all PRs:

  • [ x] Signed CLA.
  • [ x] Associated README.md updated.
  • [ x] Has appropriate unit tests.

@danielnelson
Copy link
Contributor

I know this has some overlap with #2623, @tomtastic can you review?

@tomtastic
Copy link

tomtastic commented Dec 13, 2017

@danielnelson As this PR includes the zil stats collection, I'm happy for it to replace #2623, but the checks are failing, can't tell why from looking at the circleci details, @richardelling are all your unit tests OK ?

$CIRCLE_BRANCH: pull/3565
Executing 'mv /home/ubuntu/telegraf /home/ubuntu/telegraf-build/src/github.com/influxdata'
Executing 'cd /home/ubuntu/telegraf-build/src/github.com/influxdata/telegraf'
run 'go fmt ./...' to format your source code.

bash scripts/circle-test.sh returned exit code 1

@richardelling
Copy link
Contributor Author

@tomtastic my unit tests pass, but it seems the CI fails on pull from my repo?

IMHO, this PR can replace #2623 and there are more stats in the pipeline. I'll be happy to collaborate.

@tomtastic
Copy link

tomtastic commented Dec 13, 2017

No need to collaborate @richardelling, unless you can fix my zpool unit tests for issue #2616? 😁
@danielnelson can you close / cancel #2623 ?

@danielnelson danielnelson added this to the 1.6.0 milestone Dec 14, 2017
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Dec 14, 2017
@danielnelson danielnelson merged commit 92acef1 into influxdata:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants