-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.snmp): Convert enum values #11872
feat(inputs.snmp): Convert enum values #11872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hipska the direction of this is great! my only comment so far is to document the conversion options get documented in the readme when you get there :)
4716504
to
ce3e37c
Compare
@Hipska good stuff 👏🏻 |
6d0d64a
to
48c7625
Compare
48c7625
to
8e9091b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very nice @Hipska! Just have one request on changing the returned error to a nil
explicitly to help the reader to easier catch the non-error nature...
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for this contribution @Hipska!
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Required for all PRs
resolves #6330
resolves #2809
Adds new options
enum
orenum(1)
for the fieldconversion
parameter.