-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade cluster for local #4138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraidev
force-pushed
the
upgrade_local
branch
5 times, most recently
from
August 17, 2024 02:45
161c06f
to
6f4a624
Compare
fraidev
force-pushed
the
upgrade_local
branch
6 times, most recently
from
August 17, 2024 03:54
06d97d8
to
9063108
Compare
fraidev
commented
Aug 17, 2024
@@ -91,6 +97,9 @@ function validate_cluster_stable() { | |||
# $STABLE_FLUVIO topic create ${STABLE_TOPIC}-delete | |||
ci_check; | |||
|
|||
echo "Create mirror" | |||
$STABLE_FLUVIO remote register stable-remote | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe create more metadatas in a new PR here?
digikata
reviewed
Aug 19, 2024
digikata
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
fluvio cluster upgrade
subcommand to handle just the version (with a--force
for ci testing) #4136fluvio cluster upgrade
add extended logic for upgrade of metadata when it changes #4137Before:
After
Failure case:
New CI got one bug (fixed in the last commit):