Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade cluster for local #4138

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Conversation

fraidev
Copy link
Contributor

@fraidev fraidev commented Aug 14, 2024

Related:

Before:

▷ flvd cluster upgrade
SPU monitoring socket  /tmp/fluvio-spu.sock, can't be removed: No such file or directory (os error 2)
Uninstalled fluvio local components
📝 Running pre-flight checks
    ✅ Local Fluvio is not installed
    ❌ Check Clean Fluvio Local Installation failed Local Fluvio cluster wasn't deleted. Use 'resume' to resume created cluster or 'delete' before starting a new one
💔 Some pre-flight check failed!
Preflight check failed

After

Upgrade Local Fluvio cluster to version 0.11.12-dev-1? yes
Uninstalled fluvio local components
📝 Checking All Metadatas
✅ Checked All Metadata
🚀 Upgrading Local Fluvio cluster to 0.11.12-dev-1
🎉 Successfully upgraded Local Fluvio cluster to 0.11.12-dev-1
Run: fluvio cluster resume to start the cluster again, 

Failure case:

Upgrade Local Fluvio cluster to version 0.11.12-dev-1? yes                                                                                                         
📝 Checking All Metadatas
💔 Failed to check metadata: loading metadata 'Mirror' from /Users/frai/.fluvio/data/metadata/Mirror/mac.yaml

New CI got one bug (fixed in the last commit):

image

@fraidev fraidev force-pushed the upgrade_local branch 5 times, most recently from 161c06f to 6f4a624 Compare August 17, 2024 02:45
@fraidev fraidev force-pushed the upgrade_local branch 6 times, most recently from 06d97d8 to 9063108 Compare August 17, 2024 03:54
@fraidev fraidev marked this pull request as ready for review August 17, 2024 04:18
@@ -91,6 +97,9 @@ function validate_cluster_stable() {
# $STABLE_FLUVIO topic create ${STABLE_TOPIC}-delete
ci_check;

echo "Create mirror"
$STABLE_FLUVIO remote register stable-remote

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe create more metadatas in a new PR here?

@fraidev fraidev requested a review from digikata August 17, 2024 04:21
.github/workflows/ci.yml Outdated Show resolved Hide resolved
crates/fluvio-cluster/src/cli/shutdown.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fraidev fraidev added this pull request to the merge queue Aug 19, 2024
Merged via the queue into infinyon:master with commit 826b83a Aug 19, 2024
105 checks passed
@fraidev fraidev deleted the upgrade_local branch August 19, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants