Add a built-in stringifier to display the object's id() #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it was interfering with the code window (printed in the background). This can be easily triggered by pressing 'c' on a variable when you haven't set up a custom stringifier
|
Thanks! When I played around with it, I was a bit surprised that it didn't work on At any rate, LGTM! Thanks for your contribution. |
|
Yeah I do think that's worth addressing. I'm just looking through the issues list...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this as a custom stringifier for a while, but I think it is useful and generic enough to warrant inclusion as a built-in.
Use cases typically involve quickly checking whether or not two "equal" variables point to the same object.
Thoughts? I think I hooked this up in all the right places. I've also thrown in a change to use the new
ui_logto print errors when trying to run the custom stringifier, since currently the message mucks with the rendering of the debugger.