Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated workflows #1493

Merged
merged 4 commits into from
Aug 17, 2020
Merged

updated workflows #1493

merged 4 commits into from
Aug 17, 2020

Conversation

ohbus
Copy link
Contributor

@ohbus ohbus commented Aug 16, 2020

Updated Continuous Integration Workflows

  • Created a separate job named Java PR Builder for handling Pull Requests
  • Added caching of maven dependencies for both the jobs

What's the improvement for having a seperate PR builder?

  • PR builder job will not show the build as failing anymore in the readme section badge for a faulty PR.

How is caching going to help?

  • Subsequent builds will be much faster reducing overall build time
  • All artifacts from the previous build will be cached and need not be downloaded again for building the code.
  • It will update the cache if newer dependencies are added to the pom files after completion of the job.

.github/workflows/maven-ci.yml Outdated Show resolved Hide resolved
.github/workflows/maven-ci.yml Outdated Show resolved Hide resolved
.github/workflows/maven-pr-builder.yml Outdated Show resolved Hide resolved
@ohbus ohbus requested a review from iluwatar August 17, 2020 06:34
@iluwatar iluwatar added this to the 1.23.0 milestone Aug 17, 2020
@iluwatar iluwatar merged commit 1940405 into iluwatar:master Aug 17, 2020
@iluwatar
Copy link
Owner

Many thanks @ohbus, good improvement 👍🏻

@ohbus
Copy link
Contributor Author

ohbus commented Aug 17, 2020

@iluwatar Thank you so much for guiding me.

Please do mention me if the workflow needs an update.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants