chore: add more linters and make changes #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
requested review from
lumtis,
jeronimoalbi,
tbruyelle,
fadeev and
Pantani
as code owners
jeronimoalbi
previously approved these changes
Dec 8, 2022
tbruyelle
reviewed
Dec 8, 2022
tbruyelle
reviewed
Dec 8, 2022
|
@tbruyelle @jeronimoalbi do you guys like these added linters? No need to add them if they are more trouble. I tried to add ones that weren't too opinionated and only would enforce some best practices. |
I tried to have a look at all the changes, and that seems fine to me, the ones you enabled look definitively useful. |
added 2 commits
December 8, 2022 09:31
tbruyelle
previously approved these changes
Dec 9, 2022
tbruyelle
previously approved these changes
Dec 10, 2022
Pantani
previously approved these changes
Dec 12, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3256 +/- ##
=======================================
Coverage 20.07% 20.08%
=======================================
Files 385 385
Lines 30797 30829 +32
=======================================
+ Hits 6184 6192 +8
- Misses 24024 24049 +25
+ Partials 589 588 -1
|
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* errjsonchk * dupword * errorlint * exhaustive * godot * nolintlint * reassign * test helper * finalize linter file * remove unwrap * fix typo * create TODO for markdownviewr * lint fixes * re-add unwrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding:
decorderdupworderrchkjsonerrorlintexhaustivegodotgroupernolintlintreassigntenvthelper