fix(plugins): dont unload before print #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbruyelle
requested review from
lumtis,
jeronimoalbi,
aljo242,
fadeev and
Pantani
as code owners
Unloaded plugin cannot be printed because the print requires a call to `Manifest`, in order to retrieve the information to print. The fix ensures the Unload is invoked after the print. Also: - Remove the error returned on print, in favor of printing the error in the plugin line. - Replace print icons by those from the `icons` package (we get colors in return \o/) - Improve error message when the plugin path reference isn't found Fix #3236
tbruyelle
force-pushed
the
fix/print-plugins
branch
from
a3ea6e2
to
3e607ec
Compare
aljo242
previously approved these changes
Dec 6, 2022
aljo242
previously approved these changes
Dec 6, 2022
jeronimoalbi
previously approved these changes
Dec 7, 2022
tbruyelle
dismissed stale reviews from Pantani, jeronimoalbi, and aljo242
via
4c58511
jeronimoalbi
approved these changes
Dec 7, 2022
aljo242
approved these changes
Dec 7, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* fix(plugins): dont unload before print Unloaded plugin cannot be printed because the print requires a call to `Manifest`, in order to retrieve the information to print. The fix ensures the Unload is invoked after the print. Also: - Remove the error returned on print, in favor of printing the error in the plugin line. - Replace print icons by those from the `icons` package (we get colors in return \o/) - Improve error message when the plugin path reference isn't found Fix ignite#3236 Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unloaded plugin cannot be printed because the print requires a call to
Manifest, in order to retrieve the information to print.The fix ensures the Unload is invoked after the print.
Also:
iconspackage (we get colors in return \o/)Fix #3236