working on new getpot parser #9617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are you rewriting all those input files? I noticed that one transformation is to combine split blocks. This will break some documentation pages. I have purposely split blocks to include simplified subsections of test files in some cases. |
|
@dschwen - this says "do not review". When I'm ready, I'll ping for discussion. Since things in the parser will be changing a lot, it will be super easy to us to decide together what we want and adjust behavior accordingly. |
|
This was not a "review". I just don't want you to waste time on changes that you may not be aware of being breaking. |
|
Job Documentation on 3a23fed wanted to post the following: View the site here |
rwcarlsen
force-pushed
the
getpot
branch
9 times, most recently
from
1b61dad
to
603ede1
Compare
|
Job Precheck on 333d26e wanted to post the following: Your code requires style changes.
Alternatively, apply the patch found here.
|
rwcarlsen
force-pushed
the
getpot
branch
7 times, most recently
from
a851b8e
to
2d0e387
Compare
rwcarlsen
added a commit
to rwcarlsen/pika
that referenced
this pull request
Aug 17, 2017
rwcarlsen
force-pushed
the
getpot
branch
5 times, most recently
from
2e842fe
to
bdc419d
Compare
|
Job Private App tests on 3a23fed : invalidated by @rwcarlsen |
permcody
approved these changes
Aug 30, 2017
|
Alright, this is mergeable, but I'm going to open up anther ticket for several enhancements I'd like to see in another PR. See #9753. |
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Aug 30, 2017
rwcarlsen
added a commit
to rwcarlsen/hyrax
that referenced
this pull request
Aug 30, 2017
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Aug 30, 2017
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Aug 31, 2017
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Aug 31, 2017
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Sep 11, 2017
See discussion here for details: https://groups.google.com/d/msg/moose-users/yX7y9pr41iQ/BnqBZg3FDgAJ Fixes bug introduced by idaholab#9617.
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Sep 11, 2017
See discussion here for details: https://groups.google.com/d/msg/moose-users/yX7y9pr41iQ/BnqBZg3FDgAJ Fixes bug introduced by idaholab#9617.
aeslaughter
pushed a commit
to idaholab/mastodon
that referenced
this pull request
Sep 18, 2017
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Oct 2, 2017
Fix bug where a non-string-typed field value followed by EOF resulted in the field value being interpreted as a string-typed field. Adds many tests for field value+type interpretation/retrieval, string quoting and escaping, etc. ref idaholab#9617
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Oct 2, 2017
* Fixes bug where a non-string-typed field value followed by EOF resulted in the field value being interpreted as a string-typed field. * Fixes bug where floating point numbers starting with "e" or "E" (i.e. e42) were interpreted as string-typed field values. * Adds many tests for field value+type interpretation/retrieval, string quoting and escaping, etc. ref idaholab#9617
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Oct 2, 2017
* Fixes bug where a non-string-typed field value followed by EOF resulted in the field value being interpreted as a string-typed field. * Fixes bug where floating point numbers starting with "e" or "E" (i.e. e42) were interpreted as string-typed field values. * Adds many tests for field value+type interpretation/retrieval, string quoting and escaping, etc. ref idaholab#9617
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Oct 2, 2017
* Fixes bug where a non-string-typed field value followed by EOF resulted in the field value being interpreted as a string-typed field. * Fixes bug where floating point numbers starting with "e" or "E" (i.e. e42) were interpreted as string-typed field values. * Adds many tests for field value+type interpretation/retrieval, string quoting and escaping, etc. ref idaholab#9617
jarons
pushed a commit
to jarons/moose
that referenced
this pull request
Oct 5, 2017
jarons
pushed a commit
to jarons/moose
that referenced
this pull request
Oct 5, 2017
jarons
pushed a commit
to jarons/moose
that referenced
this pull request
Oct 5, 2017
See discussion here for details: https://groups.google.com/d/msg/moose-users/yX7y9pr41iQ/BnqBZg3FDgAJ Fixes bug introduced by idaholab#9617.
jarons
pushed a commit
to jarons/moose
that referenced
this pull request
Oct 5, 2017
* Fixes bug where a non-string-typed field value followed by EOF resulted in the field value being interpreted as a string-typed field. * Fixes bug where floating point numbers starting with "e" or "E" (i.e. e42) were interpreted as string-typed field values. * Adds many tests for field value+type interpretation/retrieval, string quoting and escaping, etc. ref idaholab#9617
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Oct 17, 2017
Make it easier to see what is going on, make it easier to add new input param types, and eliminate duplicated patterns. ref idaholab#9617
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Oct 17, 2017
Make it easier to see what is going on, make it easier to add new input param types, and eliminate duplicated patterns. ref idaholab#9617
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Oct 17, 2017
Make it easier to see what is going on, make it easier to add new input param types, and eliminate duplicated patterns. ref idaholab#9617
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Nov 22, 2017
Followup to the new combining capability introduced by idaholab#8411 and idaholab#9617.
aeslaughter
pushed a commit
to aeslaughter/pika
that referenced
this pull request
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more strict+robust getpot parser with much nicer error messages.