fix overflow attack

hujinlong · Mar 17, 2020 · d83db69 · d83db69
1 parent 519eac6
commit d83db69
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/api/comet/grpc/protocol.go b/api/comet/grpc/protocol.go
@@ -159,7 +159,7 @@ func (p *Proto) ReadWebsocket(ws *websocket.Conn) (err error) {
 	p.Ver = int32(binary.BigEndian.Int16(buf[_verOffset:_opOffset]))
 	p.Op = binary.BigEndian.Int32(buf[_opOffset:_seqOffset])
 	p.Seq = binary.BigEndian.Int32(buf[_seqOffset:])
-	if packLen > _maxPackSize {
+	if packLen < 0 || packLen > _maxPackSize {
 		return ErrProtoPackLen
 	}
 	if headerLen != _rawHeaderSize {