Fix RequestCounter to make it more future-proof #27406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
reviewed
Nov 9, 2023
| self.assertEqual(counter.other_request_count, 0) | ||
| self.assertEqual(counter["GET"], 0) | ||
| self.assertEqual(counter["HEAD"], 1) | ||
| self.assertEqual(counter.total_calls, 1) |
There was a problem hiding this comment.
IIRC, this means no other request, so we are good as before, right (i.e. no extra requests)
There was a problem hiding this comment.
Yep exactly! I'm counting all request types separately :)
|
I will merge once something on main is fixed. (should be soon) |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* Fix RequestCounter to make it more future-proof * code quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #27389 and #27393 (cc @amyeroberts @ydshieh).
The problem came from the fact that
transformerstest suite was trying to mockhuggingface_hub.utils.get_sessionwhich is an internal method that I sometimes move/adapt for my needs. It shouldn't change much in the future but to make it more future-proof I chose to intercept theurllib3debug logs directly. It's not perfect as urllib3 might change their logs + we could usepytest.caploginstead but at this stage I think we are fine.I also unskipped the 2 tests that were previously failing.