Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rag end2end new #17650

Merged
merged 4 commits into from
Jun 14, 2022
Merged

Rag end2end new #17650

merged 4 commits into from
Jun 14, 2022

Conversation

shamanez
Copy link
Contributor

@shamanez shamanez commented Jun 10, 2022

What does this PR do?

I revamped the rag-end2end-retriever to be compatible with the latest versions of PL and RAY. This was requested by @aaronmueller.

@patrickvonplaten

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 10, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me! Could we maybe though delete the commented out code?

@shamanez
Copy link
Contributor Author

Ok for me! Could we maybe though delete the commented out code?

Thanks a lot for the update. I did remove unwanted comments. Please let me know if I need to do anything more.

@patrickvonplaten patrickvonplaten merged commit 9068fa6 into huggingface:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants