-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode and decode copy-to-clipboard
functionality using base64
#372
Conversation
The failed tests seem to be related to a recent update of timm, and shouldn't have anything to do with this PR. |
Can you give an example of markdown that fails with current code? |
Sure thing - sorry, I had mentioned to @mishig25 privately.
|
if you add a newline between Edit ok, tested and it doesn't work: Trying with your branch Edit 2: Same error. PR: https://github.com/huggingface/huggingface.js/pull/192/files |
Ok after a few tries your fix worked! :) (github action cache...) Approving, leaving it up to @mishig25 to take at second look & merge next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
I've tested the build on transformers docs & everything is working as expected huggingface/transformers#23361
Therefore, merging the PR 🚀
(test is failing for unrelated reason to this PR)
Fixes issue where the code attribute for
copy-to-clipboard
functionality is interpreted as valid Svelte code, which leads to SSR errors.