Only add logFn function to before if logFn exists #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new implementation of #387, but fixed. Previously, we added a function which would use logFn if it exists. Since this is all this function does, if logFn does not exist, we don't need to add the function at all. This should, in theory, provide a small performance boost as well, since the operation of checking for logFn doesn't need to be performed on every request log.
no1melman
approved these changes
Feb 4, 2020
thisIsTheFoxe
added a commit
to thisIsTheFoxe/http-server
that referenced
this pull request
Mar 30, 2020
thisIsTheFoxe
added a commit
to thisIsTheFoxe/http-server
that referenced
this pull request
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new implementation of #387, but fixed.
Previously, we added a function which would use logFn if it exists.
Since this is all this function does, if logFn does not exist, we don't
need to add the function at all.
This should, in theory, provide a small performance boost as well, since
the operation of checking for logFn doesn't need to be performed on
every request log.