Raven is deprecated, switch to sentry-sdk (alerta#1056)

* Raven is deprecated, switch to sentry-sdk

* Try form first

* Remove None param

.isort.cfg

@@ -1,2 +1,2 @@
 [settings]
-known_third_party = blinker,bson,click,dateutil,flask,flask_compress,flask_cors,itsdangerous,jwt,ldap,pkg_resources,psycopg2,pymongo,pyparsing,pytz,raven,requests,requests_mock,saml2,setuptools,werkzeug,yaml
+known_third_party = blinker,bson,click,dateutil,flask,flask_compress,flask_cors,itsdangerous,jwt,ldap,pkg_resources,psycopg2,pymongo,pyparsing,pytz,requests,requests_mock,saml2,sentry_sdk,setuptools,werkzeug,yaml

alerta/app.py

@@ -1,9 +1,10 @@
 from typing import Any, Dict
 
+import sentry_sdk
 from flask import Flask
 from flask_compress import Compress
 from flask_cors import CORS
-from raven.contrib.flask import Sentry
+from sentry_sdk.integrations.flask import FlaskIntegration
 from werkzeug.contrib.fixers import ProxyFix
 
 from alerta.database.base import Database, QueryBuilder
@@ -33,13 +34,15 @@
 
 db = Database()
 qb = QueryBuilder()
-sentry = Sentry()
+# Sentry will grab DSN from SENTRY_DSN environment variable.
+sentry_sdk.init(integrations=[FlaskIntegration()])
+
 mailer = Mailer()
 plugins = Plugins()
 custom_webhooks = CustomWebhooks()
 
 
-def create_app(config_override: Dict[str, Any]=None, environment: str=None) -> Flask:
+def create_app(config_override: Dict[str, Any] = None, environment: str = None) -> Flask:
 
     app = Flask(__name__)
     app.config['ENVIRONMENT'] = environment
@@ -63,7 +66,6 @@ def create_app(config_override: Dict[str, Any]=None, environment: str=None) -> F
 
     db.init_db(app)
     qb.init_app(app)
-    sentry.init_app(app)
 
     mailer.register(app)
     plugins.register(app)
@@ -94,7 +96,7 @@ def create_app(config_override: Dict[str, Any]=None, environment: str=None) -> F
     pass
 
 
-def create_celery_app(app: Flask=None) -> 'Celery':
+def create_celery_app(app: Flask = None) -> 'Celery':
 
     from alerta.utils.format import register_custom_serializer
     register_custom_serializer()

alerta/webhooks/custom.py

@@ -24,7 +24,7 @@ def custom(webhook):
     try:
         rv = custom_webhooks.webhooks[webhook].incoming(
             query_string=request.args,
-            payload=request.get_json() or request.get_data(as_text=True) or request.form
+            payload=request.get_json() or request.form or request.get_data(as_text=True)
         )
     except Exception as e:
         raise ApiError(str(e), 400)

requirements.txt

@@ -10,5 +10,5 @@ pyparsing==2.4.0
 python-dateutil==2.8.0
 pytz==2019.1
 PyYAML==5.1
-raven==6.10.0
 requests==2.21.0
+sentry-sdk[flask]===0.10.2

setup.py

@@ -41,7 +41,7 @@ def read(filename):
         'Flask>=0.10.1',
         'Flask-Cors>=3.0.2',
         'Flask-Compress>=1.4.0',
-        'raven[flask]>=6.2.1',
+        'sentry-sdk[flask]>=0.10.2',
         'pymongo>=3.0',
         'pyparsing',
         'requests',