Optional historical dates #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def self.historical_quotes(symbol, start_date, end_date, options = {}) | ||
|
|
||
| def self.historical_quotes(symbol, start_date=nil, end_date=nil, options = {}) |
There was a problem hiding this comment.
I'm down to removing backward compatibility here (i.e. removing the start_date / end_date params altogether and fold them into options).
What do you think?
fengb
force-pushed
the
optional-historical-dates
branch
from
9c58dde
to
8c1abf1
Compare
|
@fengb thanks for these contributions! Great stuff :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not set, Yahoo passes back all of history.
If only start date is set, Yahoo passes back start date up through today.