Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rewards/:block endpoint for hotspots/accounts #735

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Add rewards/:block endpoint for hotspots/accounts #735

merged 3 commits into from
Jan 13, 2022

Conversation

madninja
Copy link
Member

@madninja madninja commented Jan 13, 2022 •
edited
Loading

danielcolinjames
danielcolinjames suggested changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@danielcolinjames danielcolinjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just a few small typos I noticed (and "rewads" in the title of this PR 🙂 )

docs/api/blockchain/accounts.mdx Outdated Show resolved Hide resolved
docs/api/blockchain/accounts.mdx Outdated Show resolved Hide resolved
matthewcarlreetz
matthewcarlreetz approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@matthewcarlreetz matthewcarlreetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@madninja madninja changed the title Add rewads/:block endpoint for hotspots/accounts Add rewards/:block endpoint for hotspots/accounts Jan 13, 2022
@madninja madninja merged commit 87fdf57 into master Jan 13, 2022
@madninja madninja deleted the madninja/rewards_block branch January 13, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewcarlreetz matthewcarlreetz matthewcarlreetz approved these changes

@danielcolinjames danielcolinjames danielcolinjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Rewards for an Account' request returns empty data and no cursor
3 participants
@madninja @matthewcarlreetz @danielcolinjames