Issue #1200 Fix Cmd+Click on toolbar learn button

helgoboss · Sep 25, 2024 · 26922fb · 26922fb
1 parent 701669a
commit 26922fb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/main/src/infrastructure/proto/playtime_request_handler.rs b/main/src/infrastructure/proto/playtime_request_handler.rs
@@ -366,30 +366,27 @@ impl PlaytimeProtoRequestHandler {
                 Ok(())
             }
             TriggerMatrixAction::RemoveSimpleMappingTrigger => {
-                matrix.toggle_learn_source_by_target(SimpleMappingTarget::TriggerMatrix);
+                matrix.remove_mapping_by_target(SimpleMappingTarget::TriggerMatrix);
                 Ok(())
             }
             TriggerMatrixAction::RemoveSimpleMappingEnterSilenceModeOrPlayIgnited => {
-                matrix.toggle_learn_source_by_target(
-                    SimpleMappingTarget::EnterSilenceModeOrPlayIgnited,
-                );
+                matrix.remove_mapping_by_target(SimpleMappingTarget::EnterSilenceModeOrPlayIgnited);
                 Ok(())
             }
             TriggerMatrixAction::RemoveSimpleMappingSmartRecord => {
-                matrix.toggle_learn_source_by_target(SimpleMappingTarget::SmartRecord);
+                matrix.remove_mapping_by_target(SimpleMappingTarget::SmartRecord);
                 Ok(())
             }
             TriggerMatrixAction::RemoveSimpleMappingSequencerPlayOnOffState => {
-                matrix.toggle_learn_source_by_target(SimpleMappingTarget::SequencerPlayOnOffState);
+                matrix.remove_mapping_by_target(SimpleMappingTarget::SequencerPlayOnOffState);
                 Ok(())
             }
             TriggerMatrixAction::RemoveSimpleMappingSequencerRecordOnOffState => {
-                matrix
-                    .toggle_learn_source_by_target(SimpleMappingTarget::SequencerRecordOnOffState);
+                matrix.remove_mapping_by_target(SimpleMappingTarget::SequencerRecordOnOffState);
                 Ok(())
             }
             TriggerMatrixAction::RemoveSimpleMappingTapTempo => {
-                matrix.toggle_learn_source_by_target(SimpleMappingTarget::TapTempo);
+                matrix.remove_mapping_by_target(SimpleMappingTarget::TapTempo);
                 Ok(())
             }
             TriggerMatrixAction::TriggerSmartRecord => matrix.trigger_smart_record(false),

diff --git a/playtime-clip-engine b/playtime-clip-engine