Remove indexOfTheOnlyBit in IntSet.Internal #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treeowl
approved these changes
Sep 12, 2024
It has a complicated definition used only for 32-bit GHC. This isn't necessary because we can use countTrailingZeros as we do for 64-bit. Also drop a CPP check for 32/64-bit GHC, GHC doesn't support anything else.
meooow25
force-pushed
the
intset-bitwise
branch
from
6c0f759
to
8f327ad
Compare
meooow25
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1018
I can't tell why the special case for 32-bit GHC exists. #379 started using the GHC functions but I can't find an explanation for why only on 64-bit. @treeowl do you know?
This PR should improve performance on 32-bit systems, don't know if we want to test that. I don't have a 32-bit system.