Fix bug in BodyObserver removing wrong elements on detach due to a …

…wrong CSS attribute selector
hal · Sep 13, 2024 · f7c19c7 · f7c19c7
1 parent 90b6b84
commit f7c19c7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,12 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+### Fixed
+
+- Fix bug in `BodyObserver` removing wrong elements on detach due to a wrong CSS attribute selector
+  - Wrong selector: `<attribute>*=<id>`
+  - Correct selector: `<attribute>=<id>`
+
 ## [1.6.8] - 2024-08-21
 
 ### Added

diff --git a/core/src/main/java/org/jboss/elemento/BodyObserver.java b/core/src/main/java/org/jboss/elemento/BodyObserver.java
@@ -176,9 +176,9 @@ private static void onElementsRemoved(MutationRecord record) {
         }
     }
 
-    private static boolean isChildOfObservedElement(List<HTMLElement> elements, String attribute, String attachId) {
+    private static boolean isChildOfObservedElement(List<HTMLElement> elements, String attribute, String id) {
         for (HTMLElement element : elements) {
-            if (element.querySelector("[" + attribute + "*='" + attachId + "']") != null) {
+            if (element.querySelector("[" + attribute + "='" + id + "']") != null) {
                 return true;
             }
         }