Implementing a better data-trim #1756

jmpp · 2016-11-22T23:11:56Z

Inserting code snippets can sometimes be painful for the developer's indentation of HTML, constrained by the <pre> tag to pull code to the left like this :

  <body>
    <div class="reveal">
      <div class="slides">

          <section>
            <section>
              <pre><code class="js" data-trim>
const fs = require('fs');

fs.writeFile('filename.txt', 'Hello World!', (err) => {
  if (err) throw err;

  console.log('Le contenu du fichier a bien été modifié.');
});
              </code></pre>
            </section>
          </section>

      </div>
    </div>
  </body>

✖ This breaks the editor's code folding, and makes more difficult the reading of the code when working on large presentations.

Now with the new smart data-trim attribute, each code snippet will be processed line-by-line to be automatically reindented to the left :

No more pain for the developer to maintain his presentation code indentation, can allow code folding in the editor like you would do in a normal situation :

          <section>
            <section>
              <pre><code class="js" data-trim>
                const fs = require('fs');

                fs.writeFile('filename.txt', 'Hello World!', (err) => {
                  if (err) throw err;

                  console.log('Le contenu du fichier a bien été modifié.');
                });
              </code></pre>
            </section>
          </section>

✔

jmpp · 2016-11-25T13:47:24Z

@hakimel I read the CONTRIBUTING.md, please let me know if there is any oversight :)
Best.

hakimel · 2016-12-01T09:19:14Z

This is great. Thanks a lot!

Implementing a better data-trim

Jaiden Mispy and others added 2 commits October 5, 2016 11:16

Add note to README about how to disable scaling

3c36ee6

Better version of data-trim on code snippets

35162c1

hakimel merged commit 775d510 into hakimel:dev Dec 1, 2016

SteveDesmond-ca pushed a commit to SteveDesmond-ca/presentations that referenced this pull request Apr 19, 2017

Merge pull request hakimel#1756 from jmpp/better-data-trim

3fecc48

Implementing a better data-trim

jmpp deleted the better-data-trim branch November 14, 2017 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing a better data-trim #1756

Implementing a better data-trim #1756

jmpp commented Nov 22, 2016 •

edited

Loading

jmpp commented Nov 25, 2016

hakimel commented Dec 1, 2016

Implementing a better data-trim #1756

Implementing a better data-trim #1756

Conversation

jmpp commented Nov 22, 2016 • edited Loading

jmpp commented Nov 25, 2016

hakimel commented Dec 1, 2016

jmpp commented Nov 22, 2016 •

edited

Loading