Fix sslcapath bug

[LaysDragon]

#634 Thanks for your suggestion I finally split two pull request.
@SISheogorath

[SISheogorath]

Well, I said moving the code, so we can remove the validation in the app.js since we already do the config validation in the config module.

No need to validate it twice.

[LaysDragon]

But what the code does is not validation ,it is reading each file from path just like other ssl option.
https://github.com/hackmdio/hackmd/blob/c794412714cdd7b0f6ebfadaf108f72098004d64/app.js#L49-L56
https://github.com/hackmdio/hackmd/blob/c794412714cdd7b0f6ebfadaf108f72098004d64/app.js#L58-L61
It shouldn't be removed from app.js.

[SISheogorath]

Yes, you are right, I misread it. Thanks for pointing me to this ^^

[SISheogorath]

Please use path.resolve() instead of path.join.

[LaysDragon]

Why don't we replace other path.join() in index.js into path.resolve()?

[SISheogorath]

We'll do this while refactoring, but right now we touch this part of the code and we should use resolve() since it doesn't break absolute paths. :)

But it should be changed to resolve() for the other paths as well.

[LaysDragon]

I just curious is there any good reason to use resolve () instead of join ()? As I know they seems to do the same thing here.

path.join(appRootPath, config.sslcapath[i])
path.resolve(appRootPath, config.sslcapath[i])

[SISheogorath]

While join will simply append the added path, resolve does always return an absolute path to the file. And it can handle absolute path as input, which join doesn't.

so when you put path.join("/opt/hackmd", "/tmp/somefile") you'll get /opt/hackmd/tmp/somefile while path.resolve("/opt/hackmd", "/tmp/somefile") returns /tmp/somefile.

[LaysDragon]

oh well.I got it.I just wondered why we'll need put two absolute path as parameter,that really weird since it isn't necessary.
Because if I specified an absolute path in config,the join() can't handle it as expected,right?:)

[SISheogorath]

resolve takes absolute paths as well as relatives, but always returns an absolute one.

As mentioned before: path.resolve("/opt/hackmd", "/tmp/somefile") returns /tmp/somefile.
But also possible: path.resolve("/opt/hackmd", "config/somefile") returns /opt/hackmd/config/somefile.

So resolve does both, while join can only handle relative paths.

[SISheogorath]

Needs a test, but basically approved

[SISheogorath]

Can you please rebase this to the latest master?

---

How to do this?

1. Check what remotes exist: git remote -v
2. If upstream doesn't exist, add it: git remote add upstream https://github.com/hackmdio/hackmd.git
3. Stash your WIP: git stash
4. Checkout master: git checkout master
5. Pull latest changes from upstream: git pull upstream master
6. Checkout the branch you worked on before: git checkout <your branch>
7. Rebase to new master branch: git rebase master
8. Resolve conflicts if they appear
9. Get your changes back: git stash pop

[LaysDragon]

wow,thanks for the tips,I don't know I can do this with git. XD