Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement csvpreview renderer #1506

Merged
merged 4 commits into from
Jul 9, 2020
Merged

Implement csvpreview renderer #1506

merged 4 commits into from
Jul 9, 2020

Conversation

Yukaii
Copy link
Member

@Yukaii Yukaii commented May 1, 2020 •
edited by jackycute
Loading

resolves #1436

Example syntax:

```csvpreview {header=true}
firstName,lastName,email,phoneNumber
John,Doe,john@doe.com,0123456789
Jane,Doe,jane@doe.com,9876543210
James,Bond,james.bond@mi6.co.uk,0612345678
```

Screenshot

Screen Shot 2020-05-01 at 12 18 38 PM

TODOs

  • codemirror overlay language mode No existing csv language mode now
  • xss check
  • update features.md

@Yukaii Yukaii temporarily deployed to codimd-feature-csvprevi-5sg1mn May 1, 2020 04:16 Inactive
@Yukaii Yukaii added this to the Next milestone May 1, 2020
@Yukaii Yukaii changed the title Implement cspreview renderer Implement csvpreview renderer May 15, 2020
@Yukaii Yukaii added the renderer 3rd party renderer issues label Jul 9, 2020
@Yukaii Yukaii self-assigned this Jul 9, 2020
@Yukaii Yukaii temporarily deployed to codimd-feature-csvprevi-lbh6eg July 9, 2020 06:55 Inactive
@Yukaii Yukaii temporarily deployed to codimd-feature-csvprevi-lbh6eg July 9, 2020 07:11 Inactive
@Yukaii Yukaii added the markdown label Jul 9, 2020
@Yukaii Yukaii requested a review from jackycute July 9, 2020 07:56
@Yukaii Yukaii temporarily deployed to codimd-feature-csvprevi-lbh6eg July 9, 2020 08:54 Inactive
@Yukaii
Implement cspreview renderer
b29d2c0 
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii
Escape html for table cell
1adf122 
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii
Update features.md
cec3c45 
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii Yukaii temporarily deployed to codimd-feature-csvprevi-lbh6eg July 9, 2020 09:14 Inactive
@Yukaii
Revert mdTokens changes
731cec6 
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii Yukaii temporarily deployed to codimd-feature-csvprevi-lbh6eg July 9, 2020 09:25 Inactive
@jackycute
Copy link
Member

Thanks @Yukaii

@jackycute jackycute merged commit 4fe0f07 into develop Jul 9, 2020
@jackycute jackycute deleted the feature/csvpreview branch July 9, 2020 09:37
@Yukaii Yukaii modified the milestones: Next, 2.2.0 Jul 20, 2020
edgarogh pushed a commit to WartaPoirier-corp/codimd that referenced this pull request Sep 21, 2021
@renovate @renovate-bot
chore(deps): update dependency mermaid to v8.11.3 (hackmdio#1506)
0a01ee3 
Signed-off-by: Renovate Bot <bot@renovateapp.com>

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackycute jackycute Awaiting requested review from jackycute

Assignees

@Yukaii Yukaii

Labels
markdown renderer 3rd party renderer issues
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Render csv codeblock as table
2 participants
@Yukaii @jackycute