Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis Builds. #524

Merged
merged 4 commits into from
Jun 6, 2017
Merged

Fix Travis Builds. #524

merged 4 commits into from
Jun 6, 2017

Conversation

aadrian
Copy link
Contributor

@aadrian aadrian commented Jun 4, 2017

Fix Travis Builds by:

  • using a Travis build matrix
  • updating to the latest JDKs for each version
  • using more memory for Java 8 (since the tests seem to give OutOfMemory with default settings on Travis) - Java 7 has no problem whatsoever.

@grandinj
Copy link
Contributor

grandinj commented Jun 5, 2017

the VM -Xmx setting is actually set inside the org.h2.build.Build class in the test(boolean) method

Note that if you bump it up too much, some tests will take longer because they deliberately trigger a out of memory condition to test the failure paths for that case

@aadrian
Copy link
Contributor Author

aadrian commented Jun 5, 2017

@grandinj If I'm not setting it for JDK 8 at all (like I'm not doing it for Java
7), it won't pass the tests at all, since it always gives out of memory with the default size Travis-CI is setting:

After increasing only for the Java 8 the memory, it's better:

but still not perfect, since for Java 8 there seems to have random errors when running them at different times:
https://travis-ci.org/aadrian/h2database/jobs/239377022

I tried to run this test battery (what TravisCI is running) on different machines with Java 8, and in 60% of the cases one of the tests if failing. Never with Java 7.

@grandinj grandinj merged commit 06023b7 into h2database:master Jun 6, 2017
@aadrian aadrian deleted the patch_1 branch June 6, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants