Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote log to debug level because it is more informative than warning #1886

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

yorinasub17
Copy link
Contributor

Originally I set this log a warn level, but then now I realize it should actually be debug level because this is more of an informational log for the end user. This information is only a warning when the user is first developing the terragrunt.hcl, but once it's setup and the user accepts the partial parsing, this log is completely use less. As such, it is more of a debug level log, where you only want it when something doesn't work.

Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging now.

@yorinasub17 yorinasub17 merged commit 7bf4dcd into master Nov 1, 2021
@yorinasub17 yorinasub17 deleted the yori-demote-log branch November 1, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants