Added Date Converter #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsers consistently report toString.call on objects (checked in
BrowserStack). Changed Type name lookup to use it so that it
automatically supports new TypeConverters, e.g., DateConverter
Object.prototype.toString.call('')
; //'[object String]'
Object.prototype.toString.call(true)
; //'[object Boolean]'
Object.prototype.toString.call(1)
; //'[object Number]'
Object.prototype.toString.call(new Date())
; //'[object Date]'
Object.prototype.toString.call([]); //'[object Array]'
The invalid data tests are failing because Date's not invalid anymore!
Replaced new Date() with {} as an example invalid Navigation Data item
Date converter was missing Invalid Date check. new Date('a','a','a')
doesn't throw an error but returns Invalid Date object (or NaN in some
browsers)
An invalid default type wasn't detected at config build time so added validation to StateInfoConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a Date Converter along the same lines as existing Type Converters.
Didn't include Time as part of the conversion (unlike the equivalent C#). Can't think when Time would be wanted in the URL. Could've added Time when non-zero but this is confusing (seem to remember that Ajax'ed dates with zero time on the server aren't zero on the client).