Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy button to gr.Markdown #8851

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Add copy button to gr.Markdown #8851

merged 6 commits into from
Jul 22, 2024

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Jul 19, 2024

Description

Adds a copy button to the markdown component.

Closes: #8642

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 19, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/8a644418d36e331af7389d7823a9940d2e79f4f4/gradio-4.38.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@8a644418d36e331af7389d7823a9940d2e79f4f4#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/8a644418d36e331af7389d7823a9940d2e79f4f4/gradio-client-1.3.0.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 19, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/markdown minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Add copy button to gr.Markdown

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair hannahblair changed the title add copy button to markdown Add copy button to gr.Markdown Jul 19, 2024
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @hannahblair!!

@abidlabs
Copy link
Member

One thing I'm curious about is why all of the stories (e.g. https://www.chromatic.com/test?appId=649585a46a67480e3074dc75&id=669ab3271c55d38fbbe39778) include the copy button even though the default value of show_copy_button is false?

@hannahblair
Copy link
Collaborator Author

thanks @abidlabs, fixed!

@hannahblair hannahblair merged commit 914b193 into main Jul 22, 2024
8 checks passed
@hannahblair hannahblair deleted the markdown-copy-btn branch July 22, 2024 11:39
@pngwn pngwn mentioned this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gr.Markdown() should have a show_copy_button
3 participants